Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add topBar settings type #182

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: add topBar settings type #182

wants to merge 3 commits into from

Conversation

guidobernal-cubos
Copy link

@guidobernal-cubos guidobernal-cubos commented Oct 11, 2024 •
edited
Loading

What problem is this solving?

This change allows customization of the top bar appearance (name and color) in B2B settings.

How to test it?

Get:
image

{
  getB2BSettings {
    uiSettings {
      showModal
      clearCart
      topBar {
        name
        hexColor
      }
    }
  }
}

Insert:
image

mutation {
  saveB2BSettings(
    input: {
      uiSettings: {
        showModal: true
        clearCart: false
        topBar: {
          name: "Top Bar Example"
          hexColor: "#FF5733"
        }
      }
    }
  ) {
    status
  }
}

https://guidobernal--b2bstore005.myvtex.com/admin/graphql-ide

Screenshots or example usage:

As it's just a type addition, there is no concrete usage example. Testing can be done through schema verification.

Describe alternatives you've considered, if any.

No alternatives.

Related to / Depends on

How does this PR make you feel? 🔗

:)

@vtex-io-ci-cd VTEX IO CI/CD
Copy link

vtex-io-ci-cd bot commented Oct 11, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

This was referenced Oct 17, 2024
Open
Open
@enzomerca enzomerca requested a review from a team October 22, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@guidobernal-cubos